Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resolvers]: argument binding to delegate resolvers #1611

Merged
merged 7 commits into from
Apr 2, 2023

Conversation

pekkah
Copy link
Owner

@pekkah pekkah commented Apr 2, 2023

  • [docs]: server docs update
  • [resolvers]: allow binding arguments by name to delegate resolvers and subscribers

@pekkah pekkah changed the title [docs]: server docs update [resolvers]: argument binding to delegate resolvers Apr 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2023

Codecov Report

Patch coverage: 78.14% and project coverage change: +0.16 🎉

Comparison is base (c1437ae) 72.35% compared to head (04c47f3) 72.51%.

❗ Current head 04c47f3 differs from pull request most recent head 2119b9e. Consider uploading reports for the commit 2119b9e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1611      +/-   ##
==========================================
+ Coverage   72.35%   72.51%   +0.16%     
==========================================
  Files         275      277       +2     
  Lines       10659    10758      +99     
==========================================
+ Hits         7712     7801      +89     
- Misses       2947     2957      +10     
Impacted Files Coverage Δ
src/GraphQL/Features/IArgumentBinderFeature.cs 0.00% <ø> (ø)
src/GraphQL/ValueResolution/FieldResolversMap.cs 38.98% <0.00%> (ø)
src/GraphQL/ValueResolution/ResolverBuilder.cs 66.66% <0.00%> (-22.23%) ⬇️
src/GraphQL/ValueResolution/ResolversBuilder.cs 40.84% <0.00%> (-0.59%) ⬇️
src/GraphQL/ValueResolution/SubscriberBuilder.cs 66.66% <0.00%> (-22.23%) ⬇️
src/graphql.server/GraphQLApplication.cs 0.00% <ø> (ø)
src/graphql.server/GraphQLApplicationBuilder.cs 0.00% <0.00%> (ø)
src/graphql.server/GraphQLApplicationOptions.cs 0.00% <ø> (ø)
src/graphql.server/SchemaOptions.cs 0.00% <ø> (ø)
.../graphql.server/WebApplicationBuilderExtensions.cs 0.00% <0.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pekkah pekkah enabled auto-merge (squash) April 2, 2023 17:55
@pekkah pekkah merged commit c66b25e into master Apr 2, 2023
@pekkah pekkah deleted the feature/server-docs branch April 2, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants